[feat/#137] 기록에 좋아요한 유저 목록을 조회 #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juuuuone
requested review from
2ghrms,
Ssamssamukja,
dev2yup and
yongjun0511
as code owners
yongjun0511
reviewed
Dec 27, 2025
| return new SliceResponse<>(List.of(), true); | ||
| } | ||
|
|
||
| List<Member> members = likes.stream().map(MemberLike::getMember).toList(); |
Collaborator
There was a problem hiding this comment.
이 부분 N+1문제가 터질 것 같아요.
페이징은 기존에 사용하던 Projection 적용 부탁드려요(customRepository)! 성능 차이가 큽니다!
…into feat/#137-get-liked-users
|
juuuuone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 연관 이슈
🌱 PR 요약
🛠 작업 내용
📸 스크린샷
❗️리뷰어들께